Fix xenstored's dup2() usage.

The dup2() calls had their arguments reversed. Also remove the
unnecessary close() calls.

Signed-off-by: John Levon <john.levon@sun.com>

diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c
index e68004ad05bc288b0d6b4e3e4c35654586f80fab..1b9b32d67d86b88a9d734e01d207bf26fde3361e 100644 (file)
--- a/tools/xenstore/xenstored_core.c
+++ b/tools/xenstore/xenstored_core.c
@@ -1878,14 +1878,14 @@ int main(int argc, char *argv[])
                fflush(stdout);
        }
 
-       /* close stdin/stdout now we're ready to accept connections */
+       /* redirect to /dev/null now we're ready to accept connections */
        if (dofork) {
                int devnull = open("/dev/null", O_RDWR);
                if (devnull == -1)
                        barf_perror("Could not open /dev/null\n");
-               close(STDIN_FILENO);  dup2(STDIN_FILENO, devnull);
-               close(STDOUT_FILENO); dup2(STDOUT_FILENO, devnull);
-               close(STDERR_FILENO); dup2(STDERR_FILENO, devnull);
+               dup2(devnull, STDIN_FILENO);
+               dup2(devnull, STDOUT_FILENO);
+               dup2(devnull, STDERR_FILENO);
                close(devnull);
                xprintf = trace;
        }